clairemcginty commented on code in PR #1241:
URL: https://github.com/apache/parquet-mr/pull/1241#discussion_r1439698797
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetWriter.java:
##########
@@ -403,15 +405,29 @@ public ParquetWriter(Path file, Configuration conf,
WriteSupport<T> writeSupport
this.codecFactory = codecFactory;
CompressionCodecFactory.BytesInputCompressor compressor =
codecFactory.getCompressor(compressionCodecName);
+
+ final String extraMetadataConfPrefix =
ParquetOutputFormat.EXTRA_WRITE_METADATA + ".";
+ final Map<String, String> extraMetadata = new
HashMap<>(writeContext.getExtraMetaData());
+
+ conf.iterator().forEachRemaining(entry -> {
Review Comment:
I think the `ParquetProperties` approach might be cleanest -- I prototyped
adding an additional `ParquetWriter#addKeyValueMetadata` method (as in your
Arrow PR), but the problem is that we'd have to re-initialize
`ParquetWriter::writer` every time it's invoked, since it's constructed with a
metadata argument:
https://github.com/apache/parquet-mr/blob/238b9a2/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetWriter.java#L410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
