[ 
https://issues.apache.org/jira/browse/PARQUET-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jinpeng Zhou updated PARQUET-2423:
----------------------------------
    Description: 
Currently each invocation of SkipRecords() for non-repeated fields will create 
a brand new buffer object[1]. I think it probably worth keep the buffer object 
alive and just resize it for each skip, as the buffer is just a bitmap for 
records.

[1]https://github.com/apache/arrow/blob/main/cpp/src/parquet/column_reader.cc#L1482

  was:
Currently each invocation of SkipRecords() for non-repeated fields will create 
a brand new buffer object[1]. I think it probably worth keep the buffer object 
alive and just resize it for each skip, as the buffer is just a bitmap (i.e., 
should remain quite small even we don't free its memory after skip).

[1]https://github.com/apache/arrow/blob/main/cpp/src/parquet/column_reader.cc#L1482


> Avoid allocating buffer obeject in RecordReader's SkipRecords
> -------------------------------------------------------------
>
>                 Key: PARQUET-2423
>                 URL: https://issues.apache.org/jira/browse/PARQUET-2423
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-cpp
>            Reporter: Jinpeng Zhou
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Currently each invocation of SkipRecords() for non-repeated fields will 
> create a brand new buffer object[1]. I think it probably worth keep the 
> buffer object alive and just resize it for each skip, as the buffer is just a 
> bitmap for records.
> [1]https://github.com/apache/arrow/blob/main/cpp/src/parquet/column_reader.cc#L1482



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to