wgtmac commented on code in PR #1242:
URL: https://github.com/apache/parquet-mr/pull/1242#discussion_r1468778615


##########
parquet-hadoop/pom.xml:
##########
@@ -95,6 +95,11 @@
       <artifactId>jackson-databind</artifactId>
       <version>${jackson-databind.version}</version>
     </dependency>
+    <dependency>
+      <groupId>${jackson.groupId}</groupId>

Review Comment:
   I happened to find that we have a 
[parquet-jackson](https://github.com/apache/parquet-mr/blob/master/parquet-jackson/pom.xml#L35-L46)
 module which shades jackson-core and jackson-databind. But in the 
[parquet-hadoop](https://github.com/apache/parquet-mr/blob/master/parquet-hadoop/pom.xml#L82-L97)
 (and other modules) it also explicitly depends on parquet-jackson and 
jackson-xxx at the same time. I'm not familiar with this history, do you know 
why? @gszadovszky @Fokko @shangxinli 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to