wgtmac commented on code in PR #229: URL: https://github.com/apache/parquet-format/pull/229#discussion_r1468787890
########## Encodings.md: ########## @@ -335,14 +335,15 @@ Note that, even for FIXED_LEN_BYTE_ARRAY, all lengths are encoded despite the re ### Byte Stream Split: (BYTE_STREAM_SPLIT = 9) -Supported Types: FLOAT, DOUBLE +Supported Types: INT32, INT64, FLOAT, DOUBLE, FIXED_LEN_BYTE_ARRAY Review Comment: What about still placing FLOAT and DOUBLE in the beginning? ########## Encodings.md: ########## @@ -335,14 +335,15 @@ Note that, even for FIXED_LEN_BYTE_ARRAY, all lengths are encoded despite the re ### Byte Stream Split: (BYTE_STREAM_SPLIT = 9) -Supported Types: FLOAT, DOUBLE +Supported Types: INT32, INT64, FLOAT, DOUBLE, FIXED_LEN_BYTE_ARRAY Review Comment: Or add some comment to let readers know the format versions they have been added? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
