wgtmac commented on code in PR #1279:
URL: https://github.com/apache/parquet-mr/pull/1279#discussion_r1500340289
##########
parquet-column/src/main/java/org/apache/parquet/internal/column/columnindex/ColumnIndexBuilder.java:
##########
@@ -673,6 +667,6 @@ public int getPageCount() {
* @return the sum of size in bytes of the min/max values added so far to
this builder
*/
public long getMinMaxSize() {
- return minMaxSize;
+ return 0;
Review Comment:
Should we throw instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
