gszadovszky commented on code in PR #1278:
URL: https://github.com/apache/parquet-mr/pull/1278#discussion_r1500370101
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java:
##########
@@ -381,6 +386,33 @@ public ParquetFileWriter(
null);
}
+ public ParquetFileWriter(
+ OutputFile file,
+ MessageType schema,
+ Mode mode,
+ long rowGroupSize,
+ int maxPaddingSize,
+ int columnIndexTruncateLength,
+ int statisticsTruncateLength,
+ boolean pageWriteChecksumEnabled,
+ FileEncryptionProperties encryptionProperties,
+ ByteBufferAllocator allocator)
+ throws IOException {
+ this(
+ file,
+ schema,
+ mode,
+ rowGroupSize,
+ maxPaddingSize,
+ columnIndexTruncateLength,
+ statisticsTruncateLength,
+ pageWriteChecksumEnabled,
+ encryptionProperties,
+ null,
+ allocator);
+ }
+
+ @Deprecated
Review Comment:
From one hand I completely agree. From the other hand, ParquetFileWriter
should be an internal class. It is unfortunate that it is public. I would not
create yet another parameters builder for ParquetFileWriter.
I'll think about a solution somewhere in between.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
