wgtmac commented on code in PR #231: URL: https://github.com/apache/parquet-format/pull/231#discussion_r1502217613
########## Encodings.md: ########## @@ -247,6 +253,15 @@ and handled as wrapping around in 2's complement notation so that the original values are correctly restituted. This may require explicit care in some programming languages (for example by doing all arithmetic in the unsigned domain). +One strategy that might be employed to avoid the above mentioned overflow is to Review Comment: ```suggestion One strategy that might be employed to reproduce the above mentioned overflow is to ``` ########## Encodings.md: ########## @@ -247,6 +253,15 @@ and handled as wrapping around in 2's complement notation so that the original values are correctly restituted. This may require explicit care in some programming languages (for example by doing all arithmetic in the unsigned domain). +One strategy that might be employed to avoid the above mentioned overflow is to Review Comment: ```suggestion One strategy that might be employed to reproduce the above mentioned overflow is to ``` ########## Encodings.md: ########## @@ -179,6 +179,12 @@ This encoding is adapted from the Binary packing described in ["Decoding billions of integers per second through vectorization"](http://arxiv.org/pdf/1209.2137v5.pdf) by D. Lemire and L. Boytsov. +Delta encoding is best when used on sorted data, or data with runs of repeated Review Comment: Is it better to move it to the `Characteristics` section below? IMHO, we should not provide detail guidance like this because different users may have various opinions on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
