mapleFU commented on code in PR #231: URL: https://github.com/apache/parquet-format/pull/231#discussion_r1502373259
########## Encodings.md: ########## @@ -179,6 +179,12 @@ This encoding is adapted from the Binary packing described in ["Decoding billions of integers per second through vectorization"](http://arxiv.org/pdf/1209.2137v5.pdf) by D. Lemire and L. Boytsov. +Delta encoding is best when used on sorted data, or data with runs of repeated +values. It can also be useful when the range of values is small, such as would +be the case with INT_8 data. It should *not* be used when the range of the data +would necessitate the use of large bitwidths, as could be the case with random +INT32 values. Review Comment: Just curious that int32 and int8 spelling is different. ########## Encodings.md: ########## @@ -179,6 +179,12 @@ This encoding is adapted from the Binary packing described in ["Decoding billions of integers per second through vectorization"](http://arxiv.org/pdf/1209.2137v5.pdf) by D. Lemire and L. Boytsov. +Delta encoding is best when used on sorted data, or data with runs of repeated +values. It can also be useful when the range of values is small, such as would +be the case with INT_8 data. It should *not* be used when the range of the data Review Comment: change should not to should better not? Since though not recommended, user can also do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
