tustvold commented on PR #231: URL: https://github.com/apache/parquet-format/pull/231#issuecomment-1965694586
I am likely missing some context here, but I would agree with @pitrou that an encoder producing data with more bits than the physical type is a bug in the encoder, and not to mention sub-optimal. I am, however, confused how this would come about. The deltas must all fit into the physical type, and subtracting the minimum value should therefore likewise produce values that fit into the unsigned integer of the same bit width. These offset deltas should therefore be encoded with a bit width <= the bit width of the physical type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
