mukund-thakur commented on code in PR #1139:
URL: https://github.com/apache/parquet-mr/pull/1139#discussion_r1516900018
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java:
##########
@@ -1148,12 +1148,17 @@ private void
readAllPartsVectoredOrNormal(List<ConsecutivePartList> allParts, Ch
throws IOException {
if (shouldUseVectoredIO(allParts)) {
- readVectored(allParts, builder);
- } else {
- for (ConsecutivePartList consecutiveChunks : allParts) {
- consecutiveChunks.readAll(f, builder);
+ try {
+ readVectored(allParts, builder);
+ return;
+ } catch (IOException | IllegalArgumentException |
UnsupportedOperationException e) {
+ // possible failure modes.
+ LOG.warn("readVectored() failed; falling back to normal IO", e);
Review Comment:
Do we need to support fallback? What if some parts were read successfully
and failed in later stages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
