RustedBones commented on code in PR #1296: URL: https://github.com/apache/parquet-mr/pull/1296#discussion_r1528395526
########## parquet-avro/src/test/java/org/apache/parquet/avro/TestAvroRecordConverter.java: ########## Review Comment: Previous tests did not covered nested classes. I started to adapt the original code but that lead creating many classes with code duplication. This refactoring went with the following simplification: - test valid avro with generated class - test deprecated avro (1.7 and 1.8) with same pseudo generated code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
