Fokko commented on code in PR #1310:
URL: https://github.com/apache/parquet-mr/pull/1310#discussion_r1547403543
##########
parquet-arrow/src/main/java/org/apache/parquet/arrow/schema/SchemaConverter.java:
##########
@@ -87,19 +88,21 @@
*/
public class SchemaConverter {
- // Indicates if Int96 should be converted to Arrow Timestamp
- private final boolean convertInt96ToArrowTimestamp;
+ public static final String CONVERT_INT96_TO_ARROW_TIMESTAMP =
"parquet.arrow.convertInt96AsTimestamp";
+
+ private final Configuration configuration;
/**
* For when we'll need this to be configurable
*/
public SchemaConverter() {
- this(false);
+ Configuration conf = new Configuration(false);
+ conf.setBoolean(CONVERT_INT96_TO_ARROW_TIMESTAMP, false);
+ this.configuration = conf;
}
- // TODO(PARQUET-1511): pass the parameters in a configuration object
- public SchemaConverter(final boolean convertInt96ToArrowTimestamp) {
Review Comment:
We should also keep this constructor for backward compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
