Fokko commented on code in PR #1141:
URL: https://github.com/apache/parquet-mr/pull/1141#discussion_r1576183912
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/CodecFactory.java:
##########
@@ -48,7 +51,7 @@ public class CodecFactory implements CompressionCodecFactory {
private final Map<CompressionCodecName, BytesCompressor> compressors = new
HashMap<>();
private final Map<CompressionCodecName, BytesDecompressor> decompressors =
new HashMap<>();
- protected final Configuration configuration;
Review Comment:
This causes the Iceberg build to break when bumping to 1.14.0-SNAPSHOT:
```
> Task :iceberg-parquet:compileJava FAILED
/Users/fokkodriesprong/Desktop/iceberg/parquet/src/main/java/org/apache/iceberg/parquet/ParquetCodecFactory.java:60:
error: cannot find symbol
codecClass =
configuration.getClassLoader().loadClass(codecClassName);
^
symbol: method getClassLoader()
location: variable configuration of type ParquetConfiguration
/Users/fokkodriesprong/Desktop/iceberg/parquet/src/main/java/org/apache/iceberg/parquet/ParquetCodecFactory.java:62:
error: incompatible types: ParquetConfiguration cannot be converted to
Configuration
codec = (CompressionCodec) ReflectionUtils.newInstance(codecClass,
configuration);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
