clairemcginty commented on code in PR #1328:
URL: https://github.com/apache/parquet-mr/pull/1328#discussion_r1577922105
##########
parquet-column/src/main/java/org/apache/parquet/filter2/predicate/FilterApi.java:
##########
@@ -257,6 +266,16 @@ public static <T extends Comparable<T>, C extends
Column<T> & SupportsEqNotEq> N
return new NotIn<>(column, values);
}
+ public static <T extends Comparable<T>, C extends Column<T> &
SupportsContains> Contains<T> contains(
Review Comment:
Thinking to the future, it could eventually be useful to support Array
FilterPredicates like "repeated field X contains an int field greater than Y".
We could refactor this API to be written like:
```java
FilterApi.contains(
FilterApi.eq(
FilterApi.arrayColumn(FilterApi.intColumn("repeated_int_field")),
100
)
)
```
& we could eventually support `FilterApi.contains(FilterApi.lt(...))`,
`FilterApi.contains(FilterApi.gt(...))`, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
