wgtmac commented on code in PR #1221:
URL: https://github.com/apache/parquet-mr/pull/1221#discussion_r1580351194
##########
pom.xml:
##########
@@ -599,6 +599,11 @@
<!-- Due to the removal of deprecated methods -->
<exclude>org.apache.parquet.arrow.schema.SchemaMapping</exclude>
+ <!-- Make static variables final -->
+
<exclude>org.apache.parquet.avro.AvroReadSupport#AVRO_REQUESTED_PROJECTION</exclude>
Review Comment:
These are indeed breaking changes from the perspective of API but I think it
makes sense to add final keyword to them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
