Fokko commented on code in PR #1339:
URL: https://github.com/apache/parquet-mr/pull/1339#discussion_r1587620318
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetWriter.java:
##########
@@ -503,8 +503,7 @@ protected Builder(OutputFile path) {
* @return an appropriate WriteSupport for the object model.
*/
protected WriteSupport<T> getWriteSupport(ParquetConfiguration conf) {
- throw new UnsupportedOperationException(
Review Comment:
Thinking of it, I believe we should deprecate the ones where you need to
pass in Configuration (from Hadoop), and then we can move to
`ParquetConfiguration` where you can also pass in a
`HadoopParquetConfiguration`. Thanks for raising this, let me create a commit
and let me know what you think!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
