pitrou commented on code in PR #242:
URL: https://github.com/apache/parquet-format/pull/242#discussion_r1603542270
##########
src/main/thrift/parquet.thrift:
##########
@@ -835,6 +864,63 @@ struct ColumnMetaData {
16: optional SizeStatistics size_statistics;
}
+struct ColumnChunkMetaDataV3 {
+ /** REMOVED from v1: type (redundant with SchemaElementV3) */
+ /** REMOVED from v1: encodings (unnecessary and non-trivial to get right) */
+ /** REMOVED from v1: path_in_schema (unnecessary and wasteful) */
+ /** REMOVED from v1: index_page_offset (unused in practice?) */
+ /** REMOVED from v1: statistics (use ColumnIndex and/or page-level
statistics instead) */
Review Comment:
Ok, it seems it would be more reasonable to keep the statistics field for
the time being, especially as it's entirely optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
