RustedBones commented on code in PR #1349:
URL: https://github.com/apache/parquet-mr/pull/1349#discussion_r1604468860
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/metadata/ColumnChunkMetaData.java:
##########
@@ -380,13 +382,15 @@ public PrimitiveType getPrimitiveType() {
/**
* @return the stats for this column
*/
+ @JsonIgnore
Review Comment:
yes, with that annotation, all stats are skipped from logging. That's a
behavior change.
I did so to align behavior with the newly added `SizeStatistics`. As the
default implementation throws an exception, we can't safely serialize this
field so I added `JsonIgnore` annotation there too. (I'm actually wondering why
`null` is not returned as default).
If we decide to serialize the `SizeStatistics`, I'm also wondering how we
should handle [invalid
stats](https://github.com/apache/parquet-mr/blob/f12229addfdca512770a0959d8074100b1e42ee5/parquet-column/src/main/java/org/apache/parquet/column/statistics/SizeStatistics.java#L49).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
