etseidl commented on code in PR #242:
URL: https://github.com/apache/parquet-format/pull/242#discussion_r1607374942
##########
src/main/thrift/parquet.thrift:
##########
@@ -914,6 +1040,32 @@ struct RowGroup {
7: optional i16 ordinal
}
+struct RowGroupV3 {
+ /** REMOVED from v1: columns.
+ * Instead, decode each FileColumnMetadataV3 individually as needed.
+ */
+
+ /** Total byte size of all the uncompressed column data in this row group **/
+ 1: required i64 total_byte_size
+
+ /** Number of rows in this row group **/
+ 2: required i64 num_rows
+
+ /** If set, specifies a sort ordering of the rows in this row group. */
+ 3: optional list<SortingColumn> sorting_columns
Review Comment:
I was going to make the same comment. I would imagine the point of
`sorting_columns` is to tip off a query engine as to which columns can be used
for filtering (and perhaps also columns used as a compount key?). I can't see
how it would make sense for this to vary per row group. Since we're blowing
things up, I'd vote to move this to FileMetaData.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
