alkis commented on code in PR #242:
URL: https://github.com/apache/parquet-format/pull/242#discussion_r1608987107
##########
src/main/thrift/parquet.thrift:
##########
@@ -467,6 +467,35 @@ struct SchemaElement {
10: optional LogicalType logicalType
}
+struct SchemaElementV3 {
Review Comment:
There is no mandate. The official parquet thrift will comment them out.
1. Writers compiled with old version of the official thrift file may write
the fields.
2. Writers compiled with new version of the official thrift file won't write
the fields.
3. Readers compiled with old version of the official thrift file may read
the fields.
4. Readers compiled with new version of the official thrift file will ignore
the fields.
5.
##########
src/main/thrift/parquet.thrift:
##########
@@ -467,6 +467,35 @@ struct SchemaElement {
10: optional LogicalType logicalType
}
+struct SchemaElementV3 {
Review Comment:
There is no mandate. The official parquet thrift will comment them out.
1. Writers compiled with old version of the official thrift file may write
the fields.
2. Writers compiled with new version of the official thrift file won't write
the fields.
3. Readers compiled with old version of the official thrift file may read
the fields.
4. Readers compiled with new version of the official thrift file will ignore
the fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
