emkornfield commented on code in PR #242:
URL: https://github.com/apache/parquet-format/pull/242#discussion_r1610694772
##########
src/main/thrift/parquet.thrift:
##########
@@ -467,6 +467,35 @@ struct SchemaElement {
10: optional LogicalType logicalType
}
+struct SchemaElementV3 {
Review Comment:
I'm OK with no cleanup of deprecated fields. Marking them semantically as
logically required for `PAR1` footers seems reasonable to me. I hope at some
point standalone PAR3 would become the default and they would not need to be
written if they present meaningful overhead once that happens.
from a wire compatibility perspective required->optional should be
forward/backward compatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
