pitrou commented on code in PR #250:
URL: https://github.com/apache/parquet-format/pull/250#discussion_r1617292511
##########
src/main/thrift/parquet.thrift:
##########
@@ -779,8 +812,12 @@ struct ColumnMetaData {
* whether we can decode those pages. **/
2: required list<Encoding> encodings
- /** Path in schema **/
- 3: required list<string> path_in_schema
+ /** Path in schema
+ * Example of deprecated a field for PAR3
Review Comment:
Obviously I'm a bit biased, but I find the approach of defining separate
structs (`FileMetadataV3`, etc.) much cleaner than tediously documenting what
is required in V1 and forbidden in V3, and vice-versa.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
