emkornfield commented on code in PR #252:
URL: https://github.com/apache/parquet-format/pull/252#discussion_r1619494407
##########
src/main/thrift/parquet.thrift:
##########
@@ -810,9 +803,13 @@ struct ColumnMetaData {
/** optional statistics for this column chunk */
12: optional Statistics statistics;
- /** Set of all encodings used for pages in this column chunk.
+ /**
+ * DEPRECATED: use is_fully_dict_encoded instead
Review Comment:
I would suggest making this a separate PR, I think we'd prefer to keep the
changes as small and focused as possible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]