etseidl commented on code in PR #250:
URL: https://github.com/apache/parquet-format/pull/250#discussion_r1621045335


##########
src/main/thrift/parquet.thrift:
##########
@@ -1115,6 +1189,34 @@ union EncryptionAlgorithm {
   2: AesGcmCtrV1 AES_GCM_CTR_V1
 }
 
+/**
+ * Embedded metadata page.
+ * 
+ * A metadata page is a data page used to store metadata about
+ * the data stored in the file. This is a key feature of PAR3
+ * footers which allow for deferred decoding of metadata.

Review Comment:
   So the page will have a PageHeader/DataPageHeader at the top? Will nulls or 
repetition be allowed, i.e. do we need definition and repetition level data? If 
not, then should we define a new page type instead so we don't have to encode 
unused level encoding types? Then we could also drop the language below about 
not writing statistics.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to