etseidl commented on code in PR #250:
URL: https://github.com/apache/parquet-format/pull/250#discussion_r1622708989


##########
src/main/thrift/parquet.thrift:
##########
@@ -792,12 +806,23 @@ struct ColumnMetaData {
   6: required i64 total_uncompressed_size

Review Comment:
   I would think `uncompressed_size` at a minimum would have to remain i64. 
I've seen single row groups with string columns that exceed 2GB in size. I'd 
argue the same for `total_compressed_size` on uncompressed data. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to