rok commented on code in PR #254: URL: https://github.com/apache/parquet-format/pull/254#discussion_r1627721788
########## README.md: ########## @@ -285,6 +285,68 @@ There are many places in the format for compatible extensions: - Encodings: Encodings are specified by enum and more can be added in the future. - Page types: Additional page types can be added and safely skipped. +### Thrift extensions +Thrift is used for metadata. The Thrift spec mandates that unknown fields are +skipped. To facilitate extensions Parquet reserves field-id `32767` of *every* +struct as an ignorable extension point. More specifically Parquet guarantees +that field-id `32767` will *never* be seen in the official Thrift IDL. The type +of this field is always `binary` for maximum extensibility and fast skipping by Review Comment: Should we make this `BYTE_ARRAY` as per https://github.com/apache/parquet-format/pull/251? ```suggestion of this field is always `BYTE_ARRAY` for maximum extensibility and fast skipping by ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
