pitrou commented on code in PR #259: URL: https://github.com/apache/parquet-format/pull/259#discussion_r1628967093
########## Encryption.md: ########## @@ -128,6 +127,26 @@ unique nonce with a length of 12 bytes (96 bits). Notice: the NIST specification uses a term “IV” for what is called “nonce” in the Parquet encryption design. +#### 4.1.4 Invocation limit +According to the section 8.3 of the NIST SP 800-38D document, one key can be used for up to +2^32 encryption operations with RGB-based nonces in the AES GCM cipher. If this limit is exceeded, +the data encryption can be broken. The bulk of modules in a parquet file are page headers and data Review Comment: I think this is a misleading way to describe things. The limit is conventional, since the real risk is nonce reuse, and nonces are 96-bit. It's not a threshold: you are not safe until 2^32, and suddenly become vulnerable beyond. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
