asfimport opened a new issue, #403:
URL: https://github.com/apache/parquet-format/issues/403

   Each Instance of ColumnFilterPredicate stores the filter values in toString 
variable eagerly. Which is not useful
   ```java
   
   static abstract class ColumnFilterPredicate<T extends Comparable<T>> 
implements FilterPredicate, Serializable  {
     private final Column<T> column;
     private final T value;
     private final String toString; 
   
   
   protected ColumnFilterPredicate(Column<T> column, T value) {
     this.column = Objects.requireNonNull(column, "column cannot be null");
   
     // Eq and NotEq allow value to be null, Lt, Gt, LtEq, GtEq however do not, 
so they guard against
     // null in their own constructors.
     this.value = value;
   
     String name = getClass().getSimpleName().toLowerCase(Locale.ENGLISH);
     this.toString = name + "(" + column.getColumnPath().toDotString() + ", " + 
value + ")";
   }
   ```
    
   
    
   
   If your filter predicate is too long/nested this can take a lot of memory 
while creating Filter.
   We have seen in our productions this can go upto 4gbs of space while opening 
multiple parquet readers
   
   Same thing is replicated in BinaryLogicalFilterPredicate. Where toString is 
eagerly calculated and stored in string and lot of duplication is happening 
while making And/or filter.
   
   I did not find use case of storing it so eagerly
   
   **Reporter**: [Abhishek 
Jain](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=abhiSumo304)
   
   <sub>**Note**: *This issue was originally created as 
[PARQUET-2220](https://issues.apache.org/jira/browse/PARQUET-2220). Please see 
the [migration 
documentation](https://issues.apache.org/jira/browse/PARQUET-2502) for further 
details.*</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to