MaxNevermind commented on code in PR #1335:
URL: https://github.com/apache/parquet-java/pull/1335#discussion_r1704904618


##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/rewrite/RewriteOptions.java:
##########
@@ -350,6 +436,28 @@ public Builder indexCacheStrategy(IndexCache.CacheStrategy 
cacheStrategy) {
       return this;
     }
 
+    /**
+     * Set a flag weather columns from join files need to overwrite columns 
from input files.
+     *
+     * @param joinColumnsOverwrite

Review Comment:
   I thought we can focus on documentation and the tests at the end after we 
agree on implementation :-) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to