wgtmac commented on PR #240:
URL: https://github.com/apache/parquet-format/pull/240#issuecomment-2270772374
Tried to catch up with the latest discussion. To incorporate new `covering`
and `crs_kind`, I'd propose following changes:
1. `crs_kind` has been added to `GeometryType`. (Do we need to make both
`crs` and `crs_kind` required?)
```
struct GeometryType {
...
/**
* Coordinate Reference System, i.e. mapping of how coordinates refer to
* precise locations on earth.
*/
3: optional string crs;
/**
* Encoding used in the above crs field.
* Currently the only allowed value is "PROJJSON".
*/
4: optional string crs_kind;
...
}
```
2. New `Covering` has been adopted and uses `binary` type for the value to
be more flexible.
```
struct Covering {
/**
* A type of covering.
* Currently accepted values are "WKT", "WKB", "S2 and "H3".
*/
1: required string kind;
/** A payload specific to kind:
* - WKT: well-known text of a POLYGON that completely covers the contents.
* This will be interpreted according to the same CRS and edges defined
by
* the logical type.
* - WKB: similar to WKT above, but encoded as well-known binary.
* - S2: A JSON array of S2 cell identifiers encoded as hexadecimal
strings.
* - H3: A JSON array of H3 cell identifiers encoded as hexadecimal
strings.
*/
2: required binary value;
}
```
3. `GeometryStatistics` uses a list of Covering support more than one
covering.
```
struct GeometryStatistics {
...
/** A list of coverings of geometries */
2: optional list<Covering> coverings;
...
}
```
@jiayuasu @paleolimbot Please let me know if these changes are appropriate.
I will update the PR if it reaches consensus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
