clairemcginty commented on issue #1452: URL: https://github.com/apache/parquet-java/issues/1452#issuecomment-2272019483
@emkornfield, those rules makes sense. I guess that logic could be checked in `ColumnIndexFilter` where we have access to repetition/definition-level histograms? It's an interesting point about null values in lists vs empty lists -- in my implementation of the Contains predicate I disallowed `contains(null)` due to difficulty in disambiguating the two. My feeling is that `[null, null]` _is_ a list of size 2, since null is a valid value for an optional type--however, this would be difficult to implement properly, since I think that the record-level filter (IncrementallyUpdatedFilterPredicate) only invokes `ValueInspector#update` on non-null items. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
