jorisvandenbossche commented on code in PR #240:
URL: https://github.com/apache/parquet-format/pull/240#discussion_r1714151257


##########
src/main/thrift/parquet.thrift:
##########
@@ -373,6 +459,56 @@ struct JsonType {
 struct BsonType {
 }
 
+/**
+ * Physical type and encoding for the geometry type.
+ */
+enum GeometryEncoding {
+  /**
+   * Allowed for physical type: BYTE_ARRAY.
+   *
+   * Well-known binary (WKB) representations of geometries. It supports 2D or

Review Comment:
   Shall we specify here that this should be ISO WKB (and not "extended WKB", 
using the terminology of https://libgeos.org/specifications/wkb/). 
   
   The text in the geoparquet spec about this: 
https://github.com/opengeospatial/geoparquet/blob/main/format-specs/geoparquet.md#wkb



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to