jp0317 commented on PR #58:
URL: https://github.com/apache/parquet-testing/pull/58#issuecomment-2292729477
> @jp0317 I've check the bad-dict file, it throw here in C++ code:
>
> ```
> if (col_start < 0 || col_length < 0) {
> throw ParquetException("Invalid column metadata (corrupt file?)");
> }
>
> if (AddWithOverflow(col_start, col_length, &col_end) || col_end >
source_size) {
> throw ParquetException("Invalid column metadata (corrupt file?)");
> }
> ```
>
> So maybe arrow-rs can also check this? ( also cc @alamb )
yes, iiuc we can first improve type conversions as mentioned
https://github.com/apache/arrow-rs/issues/6228. For this particular case the
lenth is negative but currently our rust codes just convert them as unsigned
integers directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
