pitrou commented on code in PR #57: URL: https://github.com/apache/parquet-testing/pull/57#discussion_r1719938554
########## bad_data/README.md: ########## @@ -22,3 +22,5 @@ These are files used for reproducing various bugs that have been reported. * PARQUET-1481.parquet: tests a case where a schema Thrift value has been corrupted + +* ARROW-GH-43605.parquet: In Go, file reader goroutine crashed. Review Comment: If it's a valid Parquet file and the issue was a bug in Arrow Go preventing to read it, then it should go in `data`. If it's an invalid Parquet file and the issue was that Arrow Go crashed instead of reporting a regular error, then it should go in `bad_data`. ########## bad_data/README.md: ########## @@ -22,3 +22,5 @@ These are files used for reproducing various bugs that have been reported. * PARQUET-1481.parquet: tests a case where a schema Thrift value has been corrupted + +* ARROW-GH-43605.parquet: In Go, file reader goroutine crashed. Review Comment: The criterion should be: is it a valid Parquet file or not? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
