steveloughran commented on code in PR #2955:
URL: https://github.com/apache/parquet-java/pull/2955#discussion_r1778698484
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/wrapped/io/BindingUtils.java:
##########
@@ -65,6 +99,30 @@ static <T> DynMethods.UnboundMethod loadInvocation(
}
}
+ /**
+ * Load a static method from the source class, which will be a noop() if
+ * the class is null or the method isn't found.
+ * If the class and method are not found, then an {@code
IllegalStateException}
+ * is raised on the basis that this means that the binding class is broken,
+ * rather than missing/out of date.
+ *
+ * @param <T> return type
+ * @param source source. If null, the method is a no-op.
+ * @param returnType return type class (unused)
+ * @param name method name
+ * @param parameterTypes parameters
+ *
+ * @return the method or a no-op.
+ * @throws IllegalStateException if the method is not static.
+ */
+ public static <T> DynMethods.UnboundMethod loadStaticMethod(
+ Class<?> source, Class<? extends T> returnType, String name, Class<?>...
parameterTypes) {
+
+ final DynMethods.UnboundMethod method = loadInvocation(source, returnType,
name, parameterTypes);
+ checkState(method.isStatic(), "Method is not static %s", method);
Review Comment:
good point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
