rdblue commented on code in PR #461: URL: https://github.com/apache/parquet-format/pull/461#discussion_r1807956117
########## VariantShredding.md: ########## @@ -33,140 +33,247 @@ This document focuses on the shredding semantics, Parquet representation, implic For now, it does not discuss which fields to shred, user-facing API changes, or any engine-specific considerations like how to use shredded columns. The approach builds upon the [Variant Binary Encoding](VariantEncoding.md), and leverages the existing Parquet specification. -At a high level, we replace the `value` field of the Variant Parquet group with one or more fields called `object`, `array`, `typed_value`, and `variant_value`. -These represent a fixed schema suitable for constructing the full Variant value for each row. Review Comment: I'm trying to simplify this to only require a special `typed_value` name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
