RussellSpitzer commented on code in PR #461: URL: https://github.com/apache/parquet-format/pull/461#discussion_r1815647137
########## VariantShredding.md: ########## @@ -33,176 +33,239 @@ This document focuses on the shredding semantics, Parquet representation, implic For now, it does not discuss which fields to shred, user-facing API changes, or any engine-specific considerations like how to use shredded columns. Review Comment: This is partially not true because an engine must re-incorporate shredded columns into the variant when it is being read. I think it's also okay to drop line 32. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
