wgtmac commented on code in PR #469:
URL: https://github.com/apache/parquet-format/pull/469#discussion_r1827833791
##########
LogicalTypes.md:
##########
@@ -741,18 +746,19 @@ keys.
It is required that the repeated group of key-value pairs is named `key_value`
and that its fields are named `key` and `value`. However, these names may not
be used in existing data and should not be enforced as errors when reading.
+(`key` and `value` can be identified by their position in case of misnaming.)
Some existing data incorrectly used `MAP_KEY_VALUE` in place of `MAP`. For
backward-compatibility, a group annotated with `MAP_KEY_VALUE` that is not
contained by a `MAP`-annotated group should be handled as a `MAP`-annotated
-group.
+group. `MAP_KEY_VALUE` may be used for the `key_value` group.
Examples that can be interpreted using these rules:
```
// Map<String, Integer> (nullable map, non-null values)
optional group my_map (MAP) {
Review Comment:
Is it possible to have the below one:
```
optional group my_map {
repeated group map (MAP_KEY_VALUE) {
required binary str (STRING);
required int32 num;
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
