steveloughran commented on PR #3079:
URL: https://github.com/apache/parquet-java/pull/3079#issuecomment-2511428665

   I'm going to propose the following tests to simulate failure and validate 
handling.
   
   ### openFile() raises IllegalArgumentException, open() works.
   
   open() succeeds so stream returned.
   
   
   ### openFile() raises IllegalArgumentException, open() raises IOE
   
   IOE thrown with IllegalArgumentException as suppressed
   
   ### openFile() returns a Future, whose get() raises an UncheckedIOE
   
   unchecked IOE unwrapped and thrown.
   
   
   ### openFile() returns a stream, open() raises IOE
   
   stream returned, showing open() wasn't invoked.
   
   Does that cover the codepaths?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org
For additional commands, e-mail: issues-h...@parquet.apache.org

Reply via email to