steveloughran commented on PR #3079: URL: https://github.com/apache/parquet-java/pull/3079#issuecomment-2511530962
> We might use Mockito to check if the method was invoked or not, no need for an exception Good point, and yes same codepath. My feelings about mockito are _mixed_ fwiw; tests can be very brittle and often have high maintenance costs. As this is public API stuff, not only shouldn't it be an issue -if it does fail, that's a regression. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
