rdblue commented on code in PR #474:
URL: https://github.com/apache/parquet-format/pull/474#discussion_r1879054459


##########
src/main/thrift/parquet.thrift:
##########
@@ -384,6 +384,11 @@ struct BsonType {
  * Embedded Variant logical type annotation
  */
 struct VariantType {
+  // If the Variant is shredded the version of the shredding specification 
used.
+  // Required, if the the column is shredded.
+  //
+  // See VariantShredding.md for differences between versions.
+  1: optional i8 shredding_version

Review Comment:
   What about encoding version? If we include the encoding version, that would 
help us change it in the future. For shredding, do we want to have a single 
version that includes shredding or a separate version for shredding?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org
For additional commands, e-mail: issues-h...@parquet.apache.org

Reply via email to