Fokko commented on code in PR #3098:
URL: https://github.com/apache/parquet-java/pull/3098#discussion_r1915043326
##########
parquet-column/src/main/java/org/apache/parquet/filter2/predicate/Operators.java:
##########
@@ -505,6 +505,82 @@ public <R> R filter(
}
}
+ public static final class Size implements FilterPredicate, Serializable {
+ public enum Operator {
+ EQ,
+ LT,
+ LTE,
+ GT,
+ GTE
Review Comment:
I think every project uses a slightly different abbreviation:
https://github.com/apache/iceberg/blob/c0bd4bfbceeaf3cb6e4ead675fcb47232361af3c/api/src/main/java/org/apache/iceberg/transforms/ProjectionUtil.java#L42-L61
👯
##########
parquet-column/src/main/java/org/apache/parquet/filter2/predicate/Operators.java:
##########
@@ -505,6 +505,82 @@ public <R> R filter(
}
}
+ public static final class Size implements FilterPredicate, Serializable {
+ public enum Operator {
Review Comment:
I was thinking the same for the `LogicalInverter` above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
