wgtmac commented on code in PR #3126:
URL: https://github.com/apache/parquet-java/pull/3126#discussion_r1921903844
##########
parquet-column/src/main/java/org/apache/parquet/column/statistics/SizeStatistics.java:
##########
@@ -136,8 +136,10 @@ public SizeStatistics(
List<Long> definitionLevelHistogram) {
this.type = type;
this.unencodedByteArrayDataBytes = unencodedByteArrayDataBytes;
- this.repetitionLevelHistogram = repetitionLevelHistogram;
- this.definitionLevelHistogram = definitionLevelHistogram;
+ this.repetitionLevelHistogram =
+ repetitionLevelHistogram == null ? Collections.emptyList() :
repetitionLevelHistogram;
+ this.definitionLevelHistogram =
+ definitionLevelHistogram == null ? Collections.emptyList() :
definitionLevelHistogram;
Review Comment:
This is related to https://github.com/apache/parquet-java/pull/3124. Other
Parquet implementations might have omitted histogram for certain max_level
values. Reading these files may cause NPE. Please also help me review that PR
as well. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
