ilanKeshet opened a new issue, #3175:
URL: https://github.com/apache/parquet-java/issues/3175

   ### Describe the enhancement requested
   
   Hi all, 
   First of all let me start by saying Thank You 🙏 
   
   Please add support for protobuf major version 4 preferably 4.29.1
   
   [At December 2023](https://protobuf.dev/news/2023-12-05/) Protobuf java 
library added support for the [Editions 
feature](https://protobuf.dev/editions/overview/)  which resulted in major 
version change starting at version 4.26 
   
   I've noticed that a PR upgrading to version 4 was previously rejected 
https://github.com/apache/parquet-java/pull/1308. 
    
   
   The error below is a result of attempting to run version 1.15.0 with 
protobuf version 4.29.1 . 
   the specific failure presented is the result of the change linked below. 
   
https://github.com/protocolbuffers/protobuf/commit/65c65c2d04b293225db150029d005056a9f078b8#diff-2228551d02c6661809ca7103db9512eef4c2d01f35556d42316543d92a89edef:~:text=Edition%20getEdition()%20%7B
 
   
   ```
   java.lang.NoSuchMethodError: 
com.google.protobuf.Descriptors$FileDescriptor.getSyntax()Lcom/google/protobuf/Descriptors$FileDescriptor$Syntax;
        at 
org.apache.parquet.proto.ProtoWriteSupport$MessageWriter.writeAllFields(ProtoWriteSupport.java:449)
        at 
org.apache.parquet.proto.ProtoWriteSupport$MessageWriter.writeTopLevelMessage(ProtoWriteSupport.java:423)
        at 
org.apache.parquet.proto.ProtoWriteSupport.write(ProtoWriteSupport.java:139)
        at 
org.apache.parquet.proto.ProtoWriteSupport.write(ProtoWriteSupport.java:74)
        at 
org.apache.parquet.hadoop.InternalParquetRecordWriter.write(InternalParquetRecordWriter.java:152)
        at org.apache.parquet.hadoop.ParquetWriter.write(ParquetWriter.java:425
   ```
   
   Many many thanks 
   🙏 
   
   ### Component(s)
   
   Protobuf


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to