rdblue commented on code in PR #2971:
URL: https://github.com/apache/parquet-java/pull/2971#discussion_r2056654454
##########
parquet-column/src/main/java/org/apache/parquet/schema/LogicalTypeAnnotation.java:
##########
@@ -147,6 +151,22 @@ protected LogicalTypeAnnotation fromString(List<String>
params) {
return float16Type();
}
},
+ GEOMETRY {
Review Comment:
@zhangfengcdt, is it possible to break up this PR and get just the logical
type annotations and translation in separately? This is quite large and would
be easier to review in parts. And getting the annotations out first allows us
to start building test files to share.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
