wgtmac commented on code in PR #494: URL: https://github.com/apache/parquet-format/pull/494#discussion_r2057861580
########## Geospatial.md: ########## @@ -94,6 +94,36 @@ Bounding box is defined as the thrift struct below in the representation of min/max value pair of coordinates from each axis. Note that X and Y Values are always present. Z and M are omitted for 2D geospatial instances. +Writers should follow the guidelines below when calculating bounding boxes in +the presence of [invalid geospatial values](#invalid-geospatial-values). + +* X and Y: Skip any invalid X or Y value and continue processing the remaining X or Y + values. Do not produce a bounding box if all X or all Y values are invalid. Review Comment: What should we do if a geometry feature has a NaN value in its X coordinate? Should we ignore all the X/Y/Z/M coordinates from it, or just ignore that specific NaN value? It seems reasonable to do the latter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
