szehon-ho commented on code in PR #494: URL: https://github.com/apache/parquet-format/pull/494#discussion_r2069304673
########## Geospatial.md: ########## @@ -94,6 +94,41 @@ Bounding box is defined as the thrift struct below in the representation of min/max value pair of coordinates from each axis. Note that X and Y Values are always present. Z and M are omitted for 2D geospatial instances. +Writers should follow the guidelines below when calculating bounding boxes in +the presence of edge cases. + +* `null` instance: Skip it and continue processing the remaining + geospatial instances. Do not produce a bounding box if all instances are null. +* Non-`null` instance with [special geospatial values](#special-geospatial-values): + * X and Y: Skip any special X or Y value and continue processing the Review Comment: I have a question here, do we mean: skip any geospatial instance with special X and Y value (ie, if a linestring has a thousand coordinates, but only one has bad X,Y value, its enough to skip whole instance?) ########## Geospatial.md: ########## @@ -94,6 +94,41 @@ Bounding box is defined as the thrift struct below in the representation of min/max value pair of coordinates from each axis. Note that X and Y Values are always present. Z and M are omitted for 2D geospatial instances. +Writers should follow the guidelines below when calculating bounding boxes in +the presence of edge cases. + +* `null` instance: Skip it and continue processing the remaining + geospatial instances. Do not produce a bounding box if all instances are null. +* Non-`null` instance with [special geospatial values](#special-geospatial-values): + * X and Y: Skip any special X or Y value and continue processing the + remaining X or Y values. Do not produce a bounding box if all X or all Y + values are special values. + + * Z: Skip any special Z value and continue processing the remaining Z values. Review Comment: nit: should we just omit 'continue processing the remaining...' in all these sections, to reduce the verbosity , as its a bit obvious? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
