rdblue commented on code in PR #3202: URL: https://github.com/apache/parquet-java/pull/3202#discussion_r2072156852
########## parquet-variant/src/main/java/org/apache/parquet/variant/VariantObjectBuilder.java: ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.parquet.variant; + +import java.util.ArrayList; + +/** + * Builder for creating Variant object, used by VariantBuilder. + */ +public class VariantObjectBuilder extends VariantBuilder { + /** The parent VariantBuilder. */ + private final VariantBuilder parent; + /** The FieldEntry list for the fields of this object. */ + private final ArrayList<VariantBuilder.FieldEntry> fields; + /** The number of values appended to this object. */ + protected long numValues = 0; + + VariantObjectBuilder(VariantBuilder parent) { + this.parent = parent; + this.fields = new ArrayList<>(); + } + + /** + * Appends an object key to this object. This method must be called before appending any value. + * @param key the key to append + */ + void appendKey(String key) { + if (fields.size() > numValues) { + throw new IllegalStateException("Cannot call appendKey() before appending an object value."); Review Comment: I think this is technically "before appending a value for the previous key" right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
