wgtmac commented on code in PR #496:
URL: https://github.com/apache/parquet-format/pull/496#discussion_r2113015000
##########
LogicalTypes.md:
##########
@@ -539,6 +543,19 @@ The sort order used for `INTERVAL` is undefined. When
writing data, no min/max
statistics should be saved for this type and if such non-compliant statistics
are found during reading, they must be ignored.
+#### INTERVAL_YEAR_MONTH
+`INTERVAL_YEAR_MONTH` is used to represent a year-month time interval, such as
+`4 years and 6 months`. It must annotate an `int32` that stores the total
number
+of months as a signed integer, which represents the interval and can be
negative.
+The time duration is independent of any timezone.
+
+#### INTERVAL_DAY_TIME
Review Comment:
```suggestion
#### INTERVAL_DAY_TIME
```
##########
LogicalTypes.md:
##########
@@ -521,7 +521,11 @@ as shown below.
</tr>
</table>
-### INTERVAL
+### INTERVAL types
+
+#### INTERVAL
+`INTERVAL` is *deprecated*. Please use `INTERVAL_YEAR_MONTH` and
`INTERVAL_DAY_TIME`
+as a more precise representation per [ANSI SQL
Standard](https://www.ibm.com/docs/en/informix-servers/14.10.0?topic=types-ansi-sql-standards-datetime-interval-values).
Review Comment:
Is there a more official link rather than an IBM documentation?
##########
LogicalTypes.md:
##########
@@ -521,7 +521,11 @@ as shown below.
</tr>
</table>
-### INTERVAL
+### INTERVAL types
Review Comment:
```suggestion
### Interval types
```
##########
src/main/thrift/parquet.thrift:
##########
@@ -494,6 +517,10 @@ union LogicalType {
16: VariantType VARIANT // no compatible ConvertedType
17: GeometryType GEOMETRY // no compatible ConvertedType
18: GeographyType GEOGRAPHY // no compatible ConvertedType
+
+ // INTERVAL types
Review Comment:
There is a section about `ColumnOrder` where we need to add a comment for
the new interval types.
##########
LogicalTypes.md:
##########
@@ -521,7 +521,11 @@ as shown below.
</tr>
</table>
-### INTERVAL
+### INTERVAL types
+
+#### INTERVAL
Review Comment:
```suggestion
#### INTERVAL
```
##########
LogicalTypes.md:
##########
@@ -539,6 +543,19 @@ The sort order used for `INTERVAL` is undefined. When
writing data, no min/max
statistics should be saved for this type and if such non-compliant statistics
are found during reading, they must be ignored.
+#### INTERVAL_YEAR_MONTH
Review Comment:
```suggestion
#### INTERVAL_YEAR_MONTH
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
