alkis commented on code in PR #3243:
URL: https://github.com/apache/parquet-java/pull/3243#discussion_r2166352821
##########
parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveComparator.java:
##########
@@ -206,6 +206,31 @@ public String toString() {
}
};
+ /*
+ * This comparator is for comparing two timestamps represented as int96
binary.
+ */
+ static final PrimitiveComparator<Binary> BINARY_AS_INT_96_COMPARATOR = new
BinaryComparator() {
Review Comment:
INT96 is a physical type and there was never a converted/logical type for
it. Ergo it is implicitly only a timestamp.
Adding `AS_INT96_TIMESTAMP` is redundant but perhaps leaves some context for
the reader on what we are comparing here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
